Project

Profile

Help

Task #7435

Comments from https://github.com/OSLL/mdbci/pull/284/files

Added by Mark Zaslavskiy over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Code review tasks
Sprint/Milestone:
Start date:
22.08.2016
Due date:
% Done:

0%

Estimated time:
Target branch:
Test scenario:

http://maxscale-jenkins.mariadb.com:8090/job/run-inner-mdbci-unit-tests/1211/

https://github.com/OSLL/mdbci/pull/316

Testing: change to some mdbci folder. checkout 7435_comments_in_pull_284
then execute
0) mkdir test_vagr && cd test_vagr
1) vagrant init baremettle/ubuntu-14.04
2) echo 'libvirt' > provider
3) vagrant up --provider libvirt
4) cd ..
5) open irb shell
6) require require './core/helper'
7) get_config_node_status 'test_vagr', ''

Expectation: output "running"

History

#1 Updated by Alexander Kaluzhny over 4 years ago

  • Status changed from New to Active / In progress

#3 Updated by Alexander Kaluzhny over 4 years ago

  • Status changed from Active / In progress to Review
  • Assignee changed from Alexander Kaluzhny to Mark Zaslavskiy

#4 Updated by Mark Zaslavskiy over 4 years ago

  • Status changed from Review to New
  • Assignee changed from Mark Zaslavskiy to Alexander Kaluzhny

Please provide link to the pull-request + provide link to LAST successful run-inner-mdbci-parametrized-tests http://maxscale-jenkins.mariadb.com:8090/job/run-inner-mdbci-parametrized-tests

#5 Updated by Alexander Kaluzhny over 4 years ago

  • Status changed from New to Active / In progress

#6 Updated by Alexander Kaluzhny over 4 years ago

  • Status changed from Active / In progress to New

#7 Updated by Alexander Kaluzhny over 4 years ago

  • Status changed from New to Active / In progress

#8 Updated by Alexander Kaluzhny over 4 years ago

  • Status changed from Active / In progress to New

#9 Updated by Alexander Kaluzhny over 4 years ago

  • Status changed from New to Active / In progress

#10 Updated by Alexander Kaluzhny over 4 years ago

  • Status changed from Active / In progress to Review
  • Assignee changed from Alexander Kaluzhny to Mark Zaslavskiy
  • Test scenario updated (diff)

#11 Updated by Mark Zaslavskiy over 4 years ago

  • Status changed from Review to New
  • Assignee changed from Mark Zaslavskiy to Alexander Kaluzhny

Please check solution at integration and parametrized tests.

#12 Updated by Alexander Kaluzhny over 4 years ago

  • Status changed from New to Active / In progress

#15 Updated by Alexander Kaluzhny over 4 years ago

#16 Updated by Mark Zaslavskiy over 4 years ago

  • Status changed from Active / In progress to New

#17 Updated by Mark Zaslavskiy over 4 years ago

For all indir calls: define variables used in scope outside.
https://github.com/OSLL/mdbci/pull/316/files#diff-2a82cb7f8b5031478d89db048420ab51R237

#18 Updated by Alexander Kaluzhny about 4 years ago

  • Status changed from New to Active / In progress

#19 Updated by Alexander Kaluzhny about 4 years ago

  • Status changed from Active / In progress to New

#20 Updated by Alexander Kaluzhny about 4 years ago

  • Status changed from New to Review
  • Assignee changed from Alexander Kaluzhny to Mark Zaslavskiy
  • Test scenario updated (diff)

http://maxscale-jenkins.mariadb.com:8090/job/run-inner-mdbci-unit-tests/1211/

https://github.com/OSLL/mdbci/pull/316/files

Testing: change to some mdbci folder. checkout 7435_comments_in_pull_284
then execute
0) mkdir test_vagr && cd test_vagr
1) vagrant init baremettle/ubuntu-14.04
2) echo 'libvirt' > provider
3) vagrant up --provider libvirt
4) cd ..
5) open irb shell
6) require require './core/helper'
7) get_config_node_status 'test_vagr', ''

Expectation: output "running"

#21 Updated by Mark Zaslavskiy about 4 years ago

  • Status changed from Review to Closed

Also available in: Atom PDF